Addressing memory leak in TPHostAnimationController where TPEffectsWindo... #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndows were being created and added to an NSSet and never removed/released johndbritton#10
|
The point of the NSStringFromClass was to preserve compatibility with OSes pre-dating CoreAnimation, but I think they can be dropped now so the code can be simplified more (no need for Class objects). Thanks for fixing the leak! |
abyssoft
added a commit
that referenced
this pull request
Apr 13, 2015
Addressing memory leak in TPHostAnimationController where TPEffectsWindo...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ws were being created and added to an NSSet and never removed/released #10
Changes:
NSStringFromClassfunction calls with a more concise call toclassfor bothCALayerandCATransaction.[NSNumber numberWithFloat:...]method call with the Obj-C literal representation of simply@(...).TPEffectsWindowswere being created and stored in the_effectWindowsset but never removed/released. This happens every time you drag to the remote machine.