Specify WebKit version to be used #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebKit exists in multiple versions, namely: 4.0: Gtk 3 / LibSoup 2 4.1: Gtk 3 / Libsoup 3 5.0: Gtk 4 / Libsoup 3 If a user happens to have the GTK 4 variant installed, foliate fails to launch: (com.github.johnfactotum.Foliate:25683): Gjs-CRITICAL **: 20:25:28.434: JS ERROR: Error: Requiring WebKit2, version none: Requiring namespace 'Gtk' version '4.0', but '3.0' is already loaded @resource:///com/github/johnfactotum/Foliate/js/main.js:23:42 @/usr/bin/foliate:9:1 Pin foliate to WebKit 2 - 4.0 to circumvent this (4.1 could possibly work, but I doubt any testing was done with Soup 3 so far) Originally reported downstream at https://bugzilla.opensuse.org/show_bug.cgi?id=1192627
|
Thanks! 4.1 should work, I think, as Foliate doesn't use libsoup directly. But probably best to use 4.0 anyway, since most apps will not be ported to libsoup3 until GNOME 42 (I think). By GNOME 42, hopefully Foliate would already be ported to GTK 4. |
This was referenced Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit exists in multiple versions, namely:
4.0: Gtk 3 / LibSoup 2
4.1: Gtk 3 / Libsoup 3
5.0: Gtk 4 / Libsoup 3
If a user happens to have the GTK 4 variant installed, foliate fails to launch:
(com.github.johnfactotum.Foliate:25683): Gjs-CRITICAL **: 20:25:28.434: JS ERROR: Error: Requiring WebKit2, version none: Requiring namespace 'Gtk' version '4.0', but '3.0' is already loaded
@resource:///com/github/johnfactotum/Foliate/js/main.js:23:42
@/usr/bin/foliate:9:1
Pin foliate to WebKit 2 - 4.0 to circumvent this (4.1 could possibly work, but I doubt any testing was done with Soup 3 so far)
Originally reported downstream at https://bugzilla.opensuse.org/show_bug.cgi?id=1192627