Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: social icons #158

Closed
MomoMoses opened this issue Jun 8, 2022 · 5 comments
Closed

Accessibility: social icons #158

MomoMoses opened this issue Jun 8, 2022 · 5 comments

Comments

@MomoMoses
Copy link
Collaborator

Social media icons at the bottom of the page are flagged as not having alt text for accessibility.
Facebook
Twitter
Instagram

"Follow the BMRC on Facebook"
"........................... on Twitter"
"............................ on Instagram"
should suffice!

johnjung added a commit to uchicago-library/bmrc that referenced this issue Jun 8, 2022
@johnjung
Copy link
Owner

johnjung commented Jun 8, 2022

This is now fixed in uchicago-library/bmrc@57d7520 and live on both bmrc-test.lib and bmrc.lib. I'm going to close this issue out, please feel free to re-open it if necessary.

@johnjung johnjung closed this as completed Jun 8, 2022
@MomoMoses
Copy link
Collaborator Author

awesome!

@MomoMoses
Copy link
Collaborator Author

MomoMoses commented Jun 9, 2022

the pages were re-crawled an hour ago, but they still show the error. Here is what they suggest as a fix for the code:
<a href="http://www.w3.org/WAI"> <img src="..." alt="Web Accessibility Initiative"/></a>
The order of things is a little different than ours, is all I can see. Can't imagine why that would matter, can you?
Here's what we have: <a alt="Follow the BMRC on Facebook" href="https://www.facebook.com/1BMRC"> plus an svg element with the image specs and source... thoughts? Wait, I think I may see the logical inconsistency -- it's an alt text for the IMAGE, not for the LINK. They say "link" but they really mean "an image used as a link," I think.

What if we put the alt text in the tag used for the icon, i.e. <i>? Seems like SiteImprove is not up with the latest greatest cool web dev!

This issue, since it occurs on almost every page, really drags down the score... :(

@MomoMoses MomoMoses reopened this Jun 9, 2022
@johnjung
Copy link
Owner

Ok- this shows up in Siteimprove as "Link without a text alternative." I switched the alt attribute on the <a> elements to an aria-label- as far as I can tell that fixes the issue. Please take a look at the site and at Siteimprove to confirm that this is fixed.

johnjung pushed a commit to uchicago-library/bmrc that referenced this issue Jun 10, 2022
@MomoMoses
Copy link
Collaborator Author

I think so! Doesn't show up. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants