Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle sort does not allow repeated shuffles #6

Closed
MomoMoses opened this issue Aug 23, 2021 · 4 comments
Closed

Shuffle sort does not allow repeated shuffles #6

MomoMoses opened this issue Aug 23, 2021 · 4 comments

Comments

@MomoMoses
Copy link
Collaborator

MomoMoses commented Aug 23, 2021

To demonstrate the issue, first do an empty search using the search box. The display defaults to an A-Z sort, which is correctly highlighted, since relevance has no meaning where there are no terms. Click on "Shuffle" to get randomly re-sorted results listing. Click again on Shuffle to get a new random sort, and nothing happens.

This same limitation holds for viewing a Browse by [facet] page. Only one Shuffle is effective. Spec is to allow for a new Shuffle every time it is clicked.

@MomoMoses MomoMoses changed the title Empty search sorting - Shuffle sort does not allow repeated shuffles Shuffle sort does not allow repeated shuffles Aug 23, 2021
@johnjung
Copy link
Owner

This is fixed in f110631, I'll push this to bmrcportal-test.lib soon.

@johnjung
Copy link
Owner

This is now live on bmrcportal-test.lib. Please take a look and I'll close this issue out.

@MomoMoses
Copy link
Collaborator Author

Looks like it's working for empty search results and for browses.

@johnjung
Copy link
Owner

That's great. I'm going to close this issue out, please feel free to re-open it if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants