Use tokio streams instead of crossbeam to fix deadlock issues #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaanDD |
|
@johnmanjiro13 Done! |
|
@johnmanjiro13 Fixed the merge conflict |
johnmanjiro13
approved these changes
Jul 18, 2023
| @@ -17,15 +17,13 @@ include = [ | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| async-trait = "0.1.61" | |||
There was a problem hiding this comment.
I'm glad to remove these dependencies 👍
Merged
|
v0.4.0 was released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues with this package causing my whole application to hang. After some debugging I found it was because of the usage of crossbeam within an async environment. I created a PR to switch to tokio streams instead which fixes this issue. There's no need to do
try_recvanymore in an infinite loop, instead the blockingrecv().awaitcall is used. I opted to usebroadcastbecause it allows forclient.sendto remain non async. This meant I had to makeRecordclonable.