Add ember-cli-babel as a dependency and clean up #12
Conversation
YoranBrondsema
commented
Jun 9, 2017
•
YoranBrondsema
commented
- Fixes Deprecation on ember-cli 2.12 #11
- Fixes Bump faker to 3.1.0 #10
- Modernizes the project by updating dependencies
- Adds a test
YoranBrondsema
changed the title
|
Tests pass locally but no on Travis :(. @johnotander I don't think I can clear the cache on Travis CI. Would you mind doing that? I have a feeling it's due to that. |
| "ember-qunit-notifications": "0.0.4", | ||
| "qunit": "~1.15.0", | ||
| "Faker": "~2.1.0" | ||
| "Faker": "4.1.0" |
There was a problem hiding this comment.
Faker is available as an npm package, removing all need to keep using Bower.
There was a problem hiding this comment.
You're right. I will look into making this change this weekend.
There was a problem hiding this comment.
@alanlalonde I tried importing Faker as an NPM module but unfortunately it's only available as a CommonJS module. I couldn't really find an easy way of importing it, in the same way the Bower component is imported (the NPM module does not export a built file). So I'd like to leave it as it is for now, and we can look into importing it as a NPM module in a future PR. In any case, this PR does quite some much needed modernizing!
There was a problem hiding this comment.
That's fine. If it'll require extra work, it can be the focus of the next modernization PR. Thanks for checking to see if it's doable on your end.
|
@johnotander Any updates? |
|
ember-browserify is an option for importing faker from npm |
|
Actually ember-cli-mirage import https://github.com/samselikoff/ember-cli-mirage/blob/master/index.js |
|
@Subtletree Perfect, thanks! I still want to merge this PR first and move away from Bower in a next PR. @johnotander in case you're not actively using this addon yourself anymore, would you mind giving contributor permissions to others so that we can continue maintaining the addon? I think there are still a few projects depending on it! You could start with me so I can get this modernization PR merged :-) |
|
Hey @YoranBrondsema, thanks for volunteering and sorry for the delay in responding. I've sent you an invite to become a collaborator so if you wanted to take over the maintenance of this project I'd be delighted 💓 . I've unfortunately been short on time for maintaining some of my libraries lately. |
|
Also, if you send along your npm username I can add you as an owner of the package so you can push new versions. |
|
@johnotander No problem, thanks! My NPM username is yoranbrondsema |
|
Added you as an owner to the npm package ❤️ |
