Parse ERB in database.yml #2
Conversation
Adds the ability to parse ERB nested in `config/database.yml`, and can load any any ENV variables that might be declared in the rails ENV. Basically, we can now understand statements like this: ``` username: <% ENV['DB_USERNAME'] %> password: <% ENV['DB_PASSWORD'] %> ```
|
I wasn't sure if there's a better way to get the rails ENV than... This also means that the command will only work from the root directory of a rails app (though I'm pretty sure that was already the case. I'd like to add some tests to this in the future, but I'll need to do some brain-thinky-do on how to approach tests here. |
| require 'optparse' | ||
| require_relative "#{Dir.pwd}/config/environment" |
There was a problem hiding this comment.
I wasn't sure if this was the best way to get the rails environment.
Also, I just realized this should probably be
require_relative File.join(Dir.pwd, 'config', 'environment')
There was a problem hiding this comment.
Yeah, this would be the cleanest way. I'll go ahead and merge though since this PR handles the erb parsing (so it's already a drastic improvement). If you want to clean it up later, feel free to open a PR. Thanks Nate!
|
Looking epic! 🍻 🎉 Honestly, I'm not too worried about implementing tests here since the scope of the project is still small and they will be lotsa work to set up. |
|
Published to rubygems as version |
Adds the ability to parse ERB nested in
config/database.yml, and canload any any ENV variables that might be declared in the rails ENV.
Basically, we can now understand statements like this: