Add support for Composer version 2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer version 2 has `composer-plugin-api` version 2. This PR updates the version constraint to `^1 || ^2` so we can support both composer versions. See [What's new in Composer 2](https://php.watch/articles/composer-2) and [UPGRADE-2.0](https://github.com/composer/composer/blob/master/UPGRADE-2.0.md#for-integrators-and-plugin-authors) for more changes in API. Empty methods `\johnpbloch\Composer\WordPressCorePlugin::deactivate()` and `\johnpbloch\Composer\WordPressCorePlugin::uninstall()` are added to make it compatible both versions.
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 94.59% 94.59%
Complexity 19 19
=========================================
Files 2 2
Lines 37 37
=========================================
Hits 35 35
Misses 2 2
Continue to review full report at Codecov.
|
|
Howdy @Ayesh, Thanks so much for taking the time to send this PR in! I ended up causing a few conflicts with your work in the process of getting the test suite to work with the latest version of PHPUnit, so I'm not sure how it's going to end up attributing the line changes to you when I resolve them and merge this in, but just in case I also gave you text credit in the changelog at the bottom of the readme. |
|
Awesome, thank you so much 🙏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
Composer version 2 has
composer-plugin-apiversion 2. This PR updates the version constraint to^1 || ^2so we can support both composer versions.See What's new in Composer 2 and UPGRADE-2.0 for more changes in API. Empty methods
\johnpbloch\Composer\WordPressCorePlugin::deactivate()and\johnpbloch\Composer\WordPressCorePlugin::uninstall()are added to make it compatible both versions.Related: composer/composer#8726
Thank you.