Bad design leads to only one scrollorama instance being usable per page, and possible conflicts with other plugins

[callumacrae]

For some reason, you're storing the settings directly on the jQuery object. This is really bad design!

https://github.com/johnpolacek/scrollorama/blob/master/js/jquery.scrollorama.js#L11-L28

You can see that it's on the jQuery object by running $.settings in the console.

This is causing weird behaviour, and will also cause a fight with any other jQuery plugin or website that tries to use $.settings (which they don't, because it's a really bad idea).

I think that it was probably an accident: the destroy function tries to remove the entire jQuery object, which probably isn't the intention! Luckily, you're using delete wrong so it doesn't work.

PR incoming 😄