Skip to content

Commit

Permalink
Add comments to differentiate two cache paths (flutter#9721)
Browse files Browse the repository at this point in the history
  • Loading branch information
liyuqian authored Jul 11, 2019
1 parent 3b94410 commit 1250c37
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 5 additions & 1 deletion shell/common/switches.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ DEF_SWITCH(IsolateSnapshotInstructions,
"isolate-snapshot-instr",
"The isolate instructions snapshot that will be memory mapped as "
"read and executable. SnapshotAssetPath must be present.")
DEF_SWITCH(CacheDirPath, "cache-dir-path", "Path to the cache directory.")
DEF_SWITCH(CacheDirPath,
"cache-dir-path",
"Path to the cache directory. "
"This is different from the persistent_cache_path in embedder.h, "
"which is used for Skia shader cache.")
DEF_SWITCH(ICUDataFilePath, "icu-data-file-path", "Path to the ICU data file.")
DEF_SWITCH(ICUSymbolPrefix,
"icu-symbol-prefix",
Expand Down
3 changes: 3 additions & 0 deletions shell/platform/embedder/embedder.h
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ typedef struct {
// Path to a directory used to store data that is cached across runs of a
// Flutter application (such as compiled shader programs used by Skia).
// This is optional. The string must be NULL terminated.
//
// This is different from the cache-path-dir argument defined in switches.h,
// which is used in |flutter::Settings| as |temp_directory_path|.
const char* persistent_cache_path;

// If true, we'll only read the existing cache, but not write new ones.
Expand Down

0 comments on commit 1250c37

Please sign in to comment.