Introduce Identifier remove a lot of Strings #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 83.16% 83.23% +0.06%
==========================================
Files 49 50 +1
Lines 3237 3256 +19
Branches 138 136 -2
==========================================
+ Hits 2692 2710 +18
- Misses 545 546 +1
Continue to review full report at Codecov.
|
johnynek
commented
Mar 26, 2019
| Referant.importedTypes(imps) | ||
|
|
||
| val resolveImportedCons: Map[String, (PackageName, ConstructorName)] = | ||
| val resolveImportedCons: Map[Identifier, (PackageName, Constructor)] = |
There was a problem hiding this comment.
Seems the key here should be Constructor.
There was a problem hiding this comment.
this isn't easy actually, imports don't know currently if the are bindable or constructors. I'm going to leave it as Identifier, which is at least an improvement.
| @@ -151,7 +153,7 @@ object DefRecursionCheck { | |||
| */ | |||
| def checkForIllegalBinds[A]( | |||
| state: State, | |||
| bs: Iterable[String], | |||
| bs: Iterable[Identifier.Bindable], | |||
There was a problem hiding this comment.
Bindable has been imported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not a fun refactor, but it was real techdebt.
Previously, we were using
Stringin many cases for identifiers. It is hard to refactor such code because we don't know which of those are referring to binding names, type names or Constructors.This introduces Identifier which is intended to keep track of this and be clear that we are never recreating those strings after parsing.
This is related to #12 and #70 since both of those will need to touch how identifiers are delt with.