Danyro/teacher onboarding bugs and update #101

danyrojj · 2020-09-10T16:29:14Z

No description provided.

…cache, listening to valueChanges

… cache

…er-onboarding-bugs-and-update

yinonov · 2020-09-11T05:41:17Z

apps/joie/src/app/models/teacher.model.ts

+  firstName: string;
+  lastName: string;
+  email: string;


@LolaRev @danyro0 why do we need these properties? we already have those in user's info. can be edited elsewhere.
can teacher have these set to different values from their user account?

this decision might also affect the UI

@LolaRev @danyro0 why do we need these properties? we already have those in user's info. can be edited elsewhere.
can teacher have these set to different values from their user account?

As mentioned, it was before we move it to the sessions. I think that we can remove the view but let's keep the shortcut for creating a session @yinon @danyro0

@yinonov it's a final data model for the onboarding flow, i think we need this interface only for giving a type to post request when we implement submitting

sure, it's a nice feature, we already has a setup for it. @danyro0 we discussed it.

can we remove this step then?

okay I'll remove it

yinonov · 2020-09-11T05:54:50Z

...ing/onboarding-student/components/activities-step/activities-box/activities-box.component.ts

@@ -22,9 +23,9 @@ export const ACTIVITIES = 'activities';
 export class ActivitiesBoxComponent implements OnInit, OnDestroy, AfterViewInit {
  @Input() pillar;
  public form: FormGroup;
-  formValueChanges$;
+  formValueChanges$: Subscription;


we handle subscriptions with untilDestroy

joie-web-app/apps/joie/src/app/sessions/components/session-details/session-details.component.ts

Line 14 in 24f0350

@UntilDestroy()

nice! way cooler

yinonov · 2020-09-11T13:48:23Z

apps/joie/src/app/onboarding/onboarding-student/components/pillar-step/pillar-step.component.ts

  @ViewChild('pillarList') pillarList: PillarListComponent;
  pillarEnum = Pillar;
-  formValueChanges$;
+  formValueChanges$: Subscription;


we handle subscriptions with untilDestroy

joie-web-app/apps/joie/src/app/sessions/components/session-details/session-details.component.ts

Line 14 in 24f0350

@UntilDestroy()

yinonov · 2020-09-14T07:34:58Z

.../onboarding/onboarding-student/components/session-types-step/session-types-step.component.ts

@@ -19,8 +22,8 @@ export class SessionTypesStepComponent implements OnDestroy {
  form: FormGroup;
  typesEnum = SessionTypes;
  sessionTypesData = sessionTypesData;
-  formValueChanges$;
-  controlKey = USER_ONBOARDING + '-' + SESSION_TYPES;
+  formValueChanges$: Subscription;


change to untilDestroy

yinonov · 2020-09-14T07:36:11Z

.../onboarding/onboarding-student/components/session-types-step/session-types-step.component.ts

  get typeKeys() {
    return Object.keys(this.typesEnum);


can we try to follow the literalMapping approach as we did for other types?

@yinonov do you think we need to implement it everywhere instead of this enum,keys pattern? i thinks it adds complexity for some cases like the activity-box

yinonov · 2020-09-14T09:08:01Z

...rding/onboarding-teacher/components/online-presence-step/online-presence-step.component.scss

@@ -1,3 +0,0 @@
-.grid-item {


Is this still relevant?

no, it's deleted :)

yinonov · 2020-09-14T11:45:23Z

...ie/src/app/onboarding/onboarding-teacher/components/why-joie-step/why-joie-step.component.ts

+  }
+
+  getCache() {
+    this.storage.getItem(this.controlKey).subscribe((cacheValue) => {


does this ever unsubscribes?

yinonov · 2020-09-14T11:46:30Z

...ie/src/app/onboarding/onboarding-teacher/components/why-joie-step/why-joie-step.component.ts

-      this.initFormWithCachedData(teacher);
-    }
+  subscribeToValueChanges() {
+    this.formValueChanges$ = this.form.valueChanges.subscribe((value) => {


use untilDestroy

…er-onboarding-bugs-and-update

yinonov

@danyro0 can u please merge live and resolve conflicts to proceed with the PR merge?

yinonov · 2020-09-14T20:46:30Z

...ing/onboarding-student/components/activities-step/activities-box/activities-box.component.ts

@@ -83,17 +84,13 @@ export class ActivitiesBoxComponent implements OnInit, OnDestroy, AfterViewInit
  }

  ngAfterViewInit(): void {
-    this.formValueChanges$ = this.form.valueChanges.subscribe((changedVal) => {
+    this.form.valueChanges.subscribe((changedVal) => {


you need to add this operator where dependent on untilDestory

Suggested change

this.form.valueChanges.subscribe((changedVal) => {

this.form.valueChanges.pipe(

untilDestroyed(this)

).subscribe((changedVal) => {

ohh, yep, gotta

…er-onboarding-bugs-and-update

danyrojj added 17 commits September 10, 2020 12:52

getting name from authService

0460a0b

+ TeacherOnboarding model, rename properties and controls

0fa70db

refactoring checkboxes approach foocus-area-step

d54d091

extending form service

87c43b0

injecting formService to session-focus-step, setting controls

a44cb03

setting focus-step values to formService

2b4db86

setting cache on valueChanges

5ed5b54

restoring session-focus-step from cache

aa1bae2

preselecting adults as default

b1e2aed

cleanup step code

8c85aa7

personal-info-step: setting controls to formService, getting/setting …

e509491

…cache, listening to valueChanges

stepper: formService, validation, changeDetection

031b7c5

personal step validation

b000e3c

experience-step: formService, validation, getting/setting cache

84e3dd4

session-focus-step validation

22a5f73

online-presence step: formService, checkbox refactor, setting/getting…

42a31b2

… cache

why-joie-step: formService, validation, setting/getting cache

1272a6e

danyrojj requested a review from yinonov September 10, 2020 16:29

danyrojj added 6 commits September 10, 2020 19:33

Merge branch 'live' of https://github.com/joie/joie into danyro/teach…

c11f854

…er-onboarding-bugs-and-update

unsubscribe err fix

c8ef373

Merge branch 'live' of https://github.com/joie/joie into danyro/teach…

7d62f36

…er-onboarding-bugs-and-update

layouts

cace464

checkbox groups error messages

ac65829

adding back step

31932fa

fix unescaped chars

393edba

yinonov requested changes Sep 14, 2020

View reviewed changes

danyrojj added 11 commits September 14, 2020 16:42

closing subscriptions with @untilDestroy

04c9f82

adding sessionTypesLiteralMap

d651904

Merge branch 'live' of https://github.com/joie/joie into danyro/teach…

68aae19

…er-onboarding-bugs-and-update

rm personal-info step from stepper routing

b0baf49

adding literal maps to pillar-list

30408c2

adding literal maps approach to activity-box

a5ca5aa

cleanup

eff432b

sessionTypes&activityBox enums convention

57c5687

session-focus, online presence; enums, models;

7ec1bc3

rm comments

b792cd4

blocking stepper after submit

95c6ec7

danyrojj mentioned this pull request Sep 16, 2020

Teachers' onboarding #114

Closed

danyrojj added 10 commits September 16, 2020 11:48

+ wordLimitValidator

7f6d764

error message

486ff6b

Merge branch 'live' of https://github.com/joie/joie into danyro/teach…

9c29c1b

…er-onboarding-bugs-and-update

restoring personal-info step

5eafaba

number length validation borders

a345c14

form keys to consts

eecd71b

adding wrapper functions and @UntilDestroy

fe50b80

error msgs for pillar step

2cc6881

error messaging sessionTypes(student)

6397abc

activities error msgs

c52ba30

yinonov requested changes Sep 19, 2020

View reviewed changes

danyrojj added 2 commits September 19, 2020 20:46

patch wrong usage of @UntilDestroyed

6db3e14

Merge branch 'live' of https://github.com/joie/joie into danyro/teach…

bc3af98

…er-onboarding-bugs-and-update

danyrojj requested a review from yinonov September 19, 2020 18:18

yinonov approved these changes Sep 20, 2020

View reviewed changes

yinonov merged commit 56845a5 into live Sep 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Danyro/teacher onboarding bugs and update #101

Danyro/teacher onboarding bugs and update #101

danyrojj commented Sep 10, 2020

yinonov Sep 11, 2020

yinonov Sep 11, 2020

LolaRev Sep 14, 2020

danyrojj Sep 14, 2020

yinonov Sep 14, 2020

danyrojj Sep 14, 2020

yinonov Sep 11, 2020

danyrojj Sep 14, 2020

yinonov Sep 11, 2020

yinonov Sep 14, 2020

yinonov Sep 14, 2020

danyrojj Sep 14, 2020

yinonov Sep 14, 2020

danyrojj Sep 14, 2020

yinonov Sep 14, 2020

yinonov Sep 14, 2020

yinonov left a comment

yinonov Sep 14, 2020

danyrojj Sep 19, 2020

-    this.form.valueChanges.subscribe((changedVal) => {
+    this.form.valueChanges.pipe(
+      untilDestroyed(this)
+    ).subscribe((changedVal) => {

Danyro/teacher onboarding bugs and update #101

Danyro/teacher onboarding bugs and update #101

Conversation

danyrojj commented Sep 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yinonov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment