Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DApp: Detailed progress modals for transactions #238

Merged
merged 18 commits into from
Jun 29, 2018

Conversation

am9u
Copy link
Contributor

@am9u am9u commented Jun 27, 2018

Update progress modals for all the transactions with better messaging about which transaction is currently in progress

@coveralls
Copy link

coveralls commented Jun 28, 2018

Pull Request Test Coverage Report for Build 4750

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.474%

Totals Coverage Status
Change from base Build 4737: 0.0%
Covered Lines: 580
Relevant Lines: 624

💛 - Coveralls

</StyledListingDetailPhaseCardContainer>
);
}

private renderCommitVote = (): JSX.Element => {
Copy link
Member

@nickreynolds nickreynolds Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something about this function's name feels wrong. should this be "renderRevealVote"?

Copy link
Member

@nickreynolds nickreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny comment

@am9u am9u merged commit 4ac05dd into master Jun 29, 2018
@am9u am9u deleted the am9u/ch1316/dapp-detailed-transactions-progress-modal branch July 5, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants