Use the Block Number and Index for Event Sorting #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure we get the correct order as specified on ethereum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sorted by block timestamp and internal ID which sometimes goes awry depending on when we receive events on the watchers from Infura. We should sort by block number and index to ensure no matter what order we receive events into the crawler, it is correct as specified by the log data when we query. This should fix some random ordering issues we have seen, which are mostly on events within the same block.
We could keep the sort by timestamp since it is pulled from the block data, but sorting instead by block number seems reasonable and more stable.
TODO
Update the processor to use the new sorting.