JOINDIN-475 Use Forwarded and X-Forwarded-For headers in Akismet check #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 8, 2014 00:57
Add new method to Request object to set the user's IP address based on whether or not there is a X-Forwarded-For is present. Also, refactor the SpamCheckService to have the ip address and user agent passed in rather than pulling them directly from _SERVER. This included updating the two usages of SpamCheckService::isCommentAcceptable to pass in the ip address and user agent.
…der class, and update Request class to use this new class.
…ginal client IP address and User Agent
Wasn't paying attention to what I was doing when I fixed the previous merge conflict, and removed this line.
|
Can one of the admins verify this patch? |
|
ok to test |
|
this is ok to test |
| * @return Boolean true if the comment is okay, false if it got rated as spam | ||
| */ | ||
| public function isCommentAcceptable($data) { | ||
| public function isCommentAcceptable($data,$userIp,$userAgent) { |
There was a problem hiding this comment.
Would we not be better off accepting a Request object here?
There was a problem hiding this comment.
Personally, I don't like services being aware of the outside world as represented by Request.
There was a problem hiding this comment.
How's about an interface representing a commenting user? That would be more extensible in the future and so this method signature wouldn't have to change if we suddenly need to judge whether something's spam on another service
|
Thanks! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JOINDIN-475
Added a new Header class that represents a Header and all of its values. This class is used by the Request class to properly set the source IP by looking for either a Forwarded header or a X-Forwarded-For header. If the Forwarded header is present, it also attempts to set the User-Agent from the values it contains.