Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in more consistent messages tab. #151

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Add in more consistent messages tab. #151

merged 3 commits into from
Jun 14, 2021

Conversation

jcblw
Copy link
Contributor

@jcblw jcblw commented Jun 14, 2021

Description

This PR implements a new and more stable version of message debugging. There is three large changes in this.

  • We now send messages over a port. To allow for better capabilities ( like pending request ), and avoid any polling.
  • We move to a model that has the devtools built into FinchAPI, so the user needs to set up nothing to get this to work.
  • We now send two messages to the devtools, one to start the process, and the other to send the response.

Testing

  • Includes test.
  • Manually tested.

Going to follow up with test on this.

Additional notes

I think the massive amounts of files removed is from the yarn lock being removed from the docs

@jcblw jcblw added core issue or PR for the core of finch-graphql package. devtools issue or PR for the finch-graphiql-devtools package. labels Jun 14, 2021
@jcblw jcblw merged commit 326b4ee into master Jun 14, 2021
@jcblw jcblw deleted the feature/port-messages branch June 14, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issue or PR for the core of finch-graphql package. devtools issue or PR for the finch-graphiql-devtools package.
Development

Successfully merging this pull request may close these issues.

1 participant