Fix handling 29 Feb in en_US Passport provider #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix handling the issue date of 29 Feb (of a leap year). Since the passports expire in 5 or 10 years, the expiration year will not be a leap year, and therefore the date needs to be adjusted to 28 Feb. Fixes joke2k#1870
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fixes
ValueErrorwhen the passport issue date is 29 Feb, and therefore the expiration date would fall on 29 Feb of a non-leap year.What was wrong
The expiration code was replacing the year within the date without accounting for the possibility that said day may not exist in the expiration year.
How this fixes it
It adjusts the date to 28 Feb.
Fixes #1870
I've also noticed that the last lines of every
ifcase is the same, so I've moved them below theifto reduce duplication.