Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Mapper Attribute #114

Merged
merged 3 commits into from
May 4, 2024
Merged

Introducing Mapper Attribute #114

merged 3 commits into from
May 4, 2024

Conversation

joelwurtz
Copy link
Member

@joelwurtz joelwurtz commented Apr 22, 2024 •
edited
Loading

This PR introduces a Mapper attribute, which will have the following goals :

  • Allow to override generator options by mapper instead of having some globals (like disable - enable check attributes by mapper)
  • Allow to autoregister mappers having this attribute (we provide a path to the config and all file having this attribute will be auto registered)

I introduce only existing options, but some may be added in a future PR :

  • DateTimeFormat
  • accessor / mutator prefixes
  • etc ...

@joelwurtz joelwurtz mentioned this pull request May 3, 2024
Closed
13 tasks
@joelwurtz joelwurtz requested a review from Korbeil May 3, 2024 12:50
Korbeil
Korbeil requested changes May 3, 2024
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also missing some documentation

src/Attribute/Mapper.php Outdated Show resolved Hide resolved
tests/Bundle/Resources/App/Api/Entity/Book.php Show resolved Hide resolved
Korbeil
Korbeil approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Korbeil
Korbeil reviewed May 4, 2024
View reviewed changes
docs/bundle/cache-warmup.md Outdated Show resolved Hide resolved
@joelwurtz joelwurtz merged commit 77e90f8 into main May 4, 2024
10 checks passed
@joelwurtz joelwurtz deleted the feat/mapper-config branch May 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelwurtz @Korbeil