feat(context): allow to set default context with an env variable #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Oct 16, 2023
src/Attribute/AsCommandArgument.php
Outdated
| @@ -5,6 +5,6 @@ | |||
| abstract class AsCommandArgument | |||
| { | |||
| public function __construct( | |||
| public readonly string|null $name = null, | |||
| public readonly null|string $name = null, | |||
There was a problem hiding this comment.
Is there a way to avoid this diff?
I really prefer string|null over null|string.
Also I prefer string? over string|null
pyrech
approved these changes
Oct 16, 2023
welcoMattic
approved these changes
Oct 16, 2023
lyrixx
force-pushed
the
feat/default-context-in-env
branch
from
0385af4
to
5a510f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be able to have a way to avoid setting the context for each command by using an env variable.
It only overrides the default context, a command executed with
--context=testwill use the test context regardless of the env variable definition