Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Change HTTP method of views API and parameters requirement #130

Closed
wants to merge 1 commit into from

Conversation

dqhuy78
Copy link

@dqhuy78 dqhuy78 commented Nov 5, 2021

No description provided.

@dqhuy78
Copy link
Author

dqhuy78 commented Nov 5, 2021

Hi @pyrech, I have closed my previous pull request and added this one following your instruction in updating the SDK, please check it. Thank you.

@dqhuy78 dqhuy78 force-pushed the update/views_api branch 3 times, most recently from 2293f27 to e195b54 Compare November 6, 2021 02:02
@mpyw
Copy link
Contributor

mpyw commented Jan 25, 2022

I think the fix is very important. Are there any plans to merge?

image
image

@pyrech
Copy link
Member

pyrech commented Jan 25, 2022

Hi @dqhuy78 and @mpyw
Sorry for this delay, I forgot to review this PR sooner 😞
Looks like there is some conflicts with some PR merged lately. Could you rebase it? We will merge it soon after that. Thanks

@damienalexandre
Copy link
Member

Fixed by #146 ; thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants