adjust CI and composer.json #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienalexandre
requested changes
May 24, 2023
There was a problem hiding this comment.
I'm happy with the two first changes, but the one on generated classes cannot be applied.
We may have to upgrade JanePHP maybe? @Korbeil what do you think about the suggested change?
| @@ -17,6 +17,8 @@ class ChatPostMessage extends \JoliCode\Slack\Api\Runtime\Client\BaseEndpoint im | |||
| { | |||
| use \JoliCode\Slack\Api\Runtime\Client\EndpointTrait; | |||
|
|
|||
| protected array $formParameters; | |||
There was a problem hiding this comment.
Sadly this file cannot be edited, it's generated by JanePHP.
There was a problem hiding this comment.
As far as I can tell we are already using the latest Jane 7.5 version so I will create an issue in that repo 👍🏻
There was a problem hiding this comment.
so... its been over a month and no one seems to care in the JanePHP repo about this issue...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152adjusted the PR to only contain composer.json and CI changes.
The 8.2 deprecation is caused by JanePHP