Properly separate message from trailers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mysterious indeed. it could be oclif or git or bash, or something else i cant think of. oclif you didnt update i guess? git could be that it changed something. bash, that seems unlikely, since it kind kinda broke for everyone at a similar time. maybe at one point we will figure it out, or maybe it will stay as another one of the great mysteries of our universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty confused about why this used to work but then didn't and now this fixes it? Like if I didn't have enough newlines then shouldn't this have been an issue all along? And if I did have enough newlines at some point then what changed where now I don't?
Mysterous!
/cc @pvinis