add snapshot, logging and fix some errors #2
Conversation
| versionFlag := flag.String("v", "", "Version or Version Group of the Project. You can use\"l\" to get the latest version.") | ||
| buildFlag := flag.String("b", "l", "(Optional) Build Number of the Project. You can use\"l\" to get the latest version.") | ||
| versionFlag := flag.String("v", "l", "(Optional) Version or Version Group of the Project. Defaults to latest version.") | ||
| buildFlag := flag.String("b", "l", "(Optional) Build Number of the Project. You can use\"l\" to get the latest version, or \"ls\" to get the latest snapshot. Defaults to latest version.") |
There was a problem hiding this comment.
s instead of ls
| buildFlag := flag.String("b", "l", "(Optional) Build Number of the Project. You can use\"l\" to get the latest version, or \"ls\" to get the latest snapshot. Defaults to latest version.") | |
| buildFlag := flag.String("b", "l", "(Optional) Build Number of the Project. You can use\"l\" to get the latest version, or \"s\" to get the latest snapshot. Defaults to latest version.") |
| "papermcdl/pkg/latest" | ||
| "papermcdl/pkg/paper_api" | ||
| "strings" | ||
| ) | ||
|
|
||
| func main() { | ||
| projectFlag := flag.String("p", "", "Project you want to download.") | ||
| versionFlag := flag.String("v", "", "Version or Version Group of the Project. You can use\"l\" to get the latest version.") | ||
| buildFlag := flag.String("b", "l", "(Optional) Build Number of the Project. You can use\"l\" to get the latest version.") | ||
| versionFlag := flag.String("v", "l", "(Optional) Version or Version Group of the Project. Defaults to latest version.") |
There was a problem hiding this comment.
Snapshot feature would be nice in the version as well.
| versionFlag := flag.String("v", "l", "(Optional) Version or Version Group of the Project. Defaults to latest version.") | |
| versionFlag := flag.String("v", "l", "(Optional) Version or Version Group of the Project. You can use \"l\" to get the latest version or \"s\" for the latest snapshot. Defaults to latest version.") |
| infoFlag := flag.Bool("i", false, "(Optional) Show info or list available only.") | ||
| flag.Parse() | ||
|
|
||
| papermcAPI := paper_api.PapermcAPI{URL: "https://papermc.io"} | ||
|
|
||
| if *projectFlag == "" && *versionFlag == "" && *buildFlag == "l" && *infoFlag == false { | ||
| // gui.StartGUI(papermcAPI) if no flags are provided |
There was a problem hiding this comment.
Remove unused line
| // gui.StartGUI(papermcAPI) if no flags are provided |
| gui.StartGUI(papermcAPI) | ||
| return | ||
| } | ||
|
|
||
| projects, err := papermcAPI.GetProjects() | ||
| if err != nil { | ||
| fmt.Println("error getting projects: ", err) | ||
| util.LogCon("error getting projects: ", err, util.Error) |
There was a problem hiding this comment.
Please use a loggin library not a login util for example https://github.com/sirupsen/logrus
|
|
||
| import "fmt" | ||
|
|
||
| func LogCon(s string, a any, logType int) { |
There was a problem hiding this comment.
Please use a loggin library not a login util for example https://github.com/sirupsen/logrus
| @@ -52,26 +52,21 @@ func (p *PapermcSelector) EnterInput() error { | |||
| case "projects": | |||
| p.project = p.List.GetSelected() | |||
| p.ShowVersionGroups(p.project) | |||
| break | |||
There was a problem hiding this comment.
Why remove the break Statements?
There was a problem hiding this comment.
they are uneeded and redundant, the program functions the same. try it
There was a problem hiding this comment.
EDIT: I mismatched Java and GO here, because both langs are looks pretty same and it is in relation with java services. Yes, in GO you are correct
Switches in java continue proceeding all cases until the end of the switch or a break statement.
For example the following code will output A B C (i run it):
switch ("a") {
case "a":
System.out.println("A");
case "b":
System.out.println("B");
case "c":
System.out.println("C");
}If the input would be a b only B C would appear in the output and so on. The break statement is important to stop running all further cases.
This is the reason why you are able to stack cases in java like the following:
switch (something) {
case 1:
case 2:
case 3:
System.out.println("Output");
}There was a problem hiding this comment.
Okay you both kinda right. When you look at the go tour you'll see that in go they are not required but in other languages they are required: https://go.dev/tour/flowcontrol/9
I've noticed some things that could be improved. I am listing the things I have changed:
for i, _can be changed tofor i)If you want any changes, Ill make sure to add another commit to the PR.