Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single line Stage update bug #130

Closed
ashishsony opened this issue Apr 4, 2013 · 3 comments
Closed

Single line Stage update bug #130

ashishsony opened this issue Apr 4, 2013 · 3 comments
Labels
component:status Status and staging

Comments

@ashishsony
Copy link

I have experienced an issue with the one line stage update through the use of '1' key and i believe its a bug.
I cant explain the bug in words, so i have reproduced the bug in a video uploaded here:
http://youtu.be/TywasUH5LAU

Meanwhile i will investigate a little more to pin down why this happens.
@jonas
Copy link
Owner

jonas commented Apr 4, 2013

Hello,

This is a "known" issue that I never bothered to investigate. I don't know how git's interactive diff accomplishes the one line stage for diffs with many mixed add/delete lines. It could be a matter of reducing the diff context.

@jonas jonas closed this as completed in dc43a33 Mar 10, 2014
@jonas
Copy link
Owner

jonas commented Mar 10, 2014

Here's a simple example of the fix in action. One test case that never worked before was staging empty lines, which now works.

stage-single-line

@jonas jonas mentioned this issue Mar 10, 2014
Closed
@liggitt
Copy link

liggitt commented Apr 30, 2014

Thanks for the fix... was happy to see that in 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:status Status and staging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas @liggitt @ashishsony