Skip to content

Conversation

ehuelsmann
Copy link
Member

Description

In case an action wants to be excluded from autorunning, or only
wants to be available when autorunning, this can't be expressed
with the current available conditions. This PR adds a condition
(with support from the workflow object) which allows this distinction.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

In case an action wants to be excluded from autorunning, or *only*
wants to be available when autorunning, this can't be expressed
with the current available conditions. This PR adds a condition
(with support from the workflow object) which allows this distinction.
@ehuelsmann ehuelsmann added this to the 2.0 milestone Jan 30, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.355% when pulling e524fb7 on autorun-condition into 8d12a8e on master.

@ehuelsmann ehuelsmann requested a review from jonasbn January 30, 2022 19:35
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like that the default is false for now.

@ehuelsmann
Copy link
Member Author

Thanks for the review!

Based on some feedback of @oliwel in the slack channel and long thoughts I've had about that, I'm converting back to Draft, because I'm not sure anymore this is the best option.

@ehuelsmann ehuelsmann marked this pull request as draft February 18, 2022 09:52
@ehuelsmann
Copy link
Member Author

Yea. After some more deliberation, closing the PR.

@ehuelsmann ehuelsmann closed this May 23, 2022
@ehuelsmann ehuelsmann deleted the autorun-condition branch August 8, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants