Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition bug? #34

Closed
klaszlo8207 opened this issue Apr 11, 2020 · 9 comments
Closed

Transition bug? #34

klaszlo8207 opened this issue Apr 11, 2020 · 9 comments

Comments

@klaszlo8207
Copy link

klaszlo8207 commented Apr 11, 2020

When I call Get.to(..., transition.fade)

I see the off transition on the previous page rightToLeft with fade (but it will be fade OUT ONLY)

Any way to create a Transition.Nothing? (and/or transitionIn/transitionOut?)

I need to handle the in and out animations too.

Thanks

@jonataslaw
Copy link
Owner

When I call Get.to(..., transition.fade)

I see the off transition on the previous page rightToLeft with fade (but it will be fade OUT ONLY)

Any way to create a Transition.Nothing? (and/or transitionIn/transitionOut?)

I need to handle the in and out animations too.

Thanks

I did not understand. Is this a bug report or a feature request?

@klaszlo8207
Copy link
Author

It is both 😂

@jonataslaw
Copy link
Owner

Hi, Get uses native transitions to prevent breaches in app stores. This does not mean that you cannot casually use a different transition, but iOS manual analysis will reject your app if all transitions are different from Cupertino.
Android uses Transitions.fade which is the default for android, and on iOS it uses Transitions.cupertino.
You do not need to use Transitions.fade, unless you want this behavior on android and iOS, and your app will likely be rejected on the AppleStore if you do.
In view of this, there is no transition bug in Get, at least not in the latest version (1.12.0), if you use an old version, please update.
For custom transitions you will need to use named routes, and use a PageRouteBuilder (instead of GetRoute) for this.

@jonataslaw
Copy link
Owner

If you want to navigate without transitions, you can use duration: Duration (seconds: 0)

Since there is no bug description here, and no clear critical resource request, I am closing this.

@klaszlo8207
Copy link
Author

Added Duration 0, but the BACK animation is STILL left to right with a 300 ms...

Please fix this!

@klaszlo8207
Copy link
Author

klaszlo8207 commented Apr 16, 2020

I need transitionOn and transitionOff properties.
It looks like you didn't handle the page OFF animation (back?)

@klaszlo8207
Copy link
Author

Sorry this was the probleme

#38

@jonataslaw jonataslaw reopened this Apr 16, 2020
@jonataslaw
Copy link
Owner

The problem about Duration not working has been resolved. Was he related in any way to this issue?
After the last update the problem still persists?

@klaszlo8207
Copy link
Author

In the latest version this was fixed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants