Fix issues with the invite members form #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,7 +276,7 @@ export default function InviteMembersForm({ | |||
| {inviteList.map((address, index) => ( | |||
| <InviteAddress | |||
| key={address} | |||
| address={address} | |||
| address={address + index} | |||
There was a problem hiding this comment.
Ah, i could take this out. I needed it for the invalid list since it could include duplicates, but for valid addresses, you're right, it's not needed
jonathan3692bf
pushed a commit
that referenced
this pull request
Jun 14, 2022
jonathan3692bf
pushed a commit
that referenced
this pull request
Jun 15, 2022
jonathan3692bf
pushed a commit
that referenced
this pull request
Jun 16, 2022
jonathan3692bf
added a commit
that referenced
this pull request
Jun 21, 2022
* Start using new fonts * Adjust dark theme primary color, use heading font for buttons * Use new logo for Navbar, make responsive for mobile * Fix navbar to look good across view-ports * Add Realms favicon and set page title to "Realms" * Polish styling with Dan * Lighten up h3,h4 and Tabs a tags * Make MembersTab items look like AccountTab items * Update colors and font weights * Change font back to Inter * Bring back bold to buttons (load normal and bold font weights) * Use images for logo and logotype * Update colors and font weights * Create NewRealmWizard and pages in realms/new/* * Update helpers and remove unncessary tailwind configurations * Update header with new logo, add new background image, disable light mode * Start building form nav buttons * Add CSS for form nav buttons, slider, and form step indicator * Fix InviteAddress "delete" button * add createGovTokenRealm hook * Add treasury by default, auto join NFT DAO * Update the 'reals/new' page * Set environment variable for enabling/disabling theme switcher * Make sure DAO params use MAX_TOKENS_TO_DISABLE when formatting value * Fix ConnectWalletButton devnet switch * Force wallet to be connected when going through form flow * Get community token mint info and show/hide authority transfer radio * Allow users to specify a council token address * Dry up the CommunityTokenDetailsForm * Dry up YesVotePercentageForm * Fix RealmWizard * Remove unnecessary FAQ string * Cleanup FormSummary * Use InputRangeSlider component in AddNFTCollectionForm * Dry up NFT data collection * Make sure NFT collection preview wraps on tablet / mobile * * Make modal for selecting nft collection from wallet * Use latest version of headlessui Dialog for modals * Simplify data for AddNFTCollectionForm * Refactor how we prepare realms * Clean up FormSummary * Dry up prepareRealmCreation * Use prepareRealmCreation in createNFTRealm * Refactor multisig wallet creation to use prepareRealmCreation * Stop using query params for tracking current step * Rename gov-token to tokenized * Guard rail minCommunityTokensToCreateProposal calculation * Fix broken link * Bring back extended typography * Fix sizing on NFTCollectionModal * Close button on NFTCollectionModal should not select collection * change the Create New Realm page backround * Add "clear" button to AddNFTCollectionForm * Make sure AdvancedOptionsDropdown is just a button * Polish up to new page. * Hide DAO description; make Input backgrounds always visible * Update form status bar in header * start making text for Multisig wallet more consistent * give steps more space between header and fields * Clean up AddNFTCollectionForm * Clean up InputRangeSlider * Feed the linter * Create new Radio Buttons * Fix typo in Form Header * update arrow icons * Rework AdvancedOptionsDropdown * Update ThresholdAdviceBox * Hide Footer when in new realms wizard * Modify the way the invite list looks and works (#3) * Add margin to InviteMembersForm field * Adjust FormFooter buttons: * have cta text * display loading state * Update FormSummary * Update font/font size of TokenInfoTable * Make FormHeader content consistently capitalized * RadioButton text should be left-aligned on mobile * Feed linter * Fix outline issue with NavButton and AdvancedOptionsDropdown * make sure buttons ease between visual states * Make FormSummary mobile friendly * Remvoe localStorage caching and show "me" on InviteMembersForm (#4) * Remove "loadingStart" and "loadingEnd" state from NewButton * refactor RadioButton * Add link to explain what a certified collection is * Fix range slider transparent border to render on mobile * Edit copy for "Multi-Signature Wallet" * Use Grey token icon instead of gradient * Move nav buttons to bottom * Adjust navbar * Address Emon issues pt. 1 * Change text in Form Summary and add commas to NFT * Fix Form Summary pt 2 * Update FormSummary pt 4 * Show Transfer mint authority radio * * Show tokenInfo table IFF token has a proper name * Change "Transfer mint authority" description based on context * make minimumNumberOfCommunityTokensToGovern required * Fix issues with the invite members form (#5) * Use "wallet" instead of "DAO" in multisig wizard * RadioButton should have proper disabled styling * Properly wire up formData * Rename "Tokenized DAO" => "Community Token DAO" * Hide council "approval threshold" from FormSummary * Make sure new page uses borders and not outlines * FormSummary will say "(To be generated)" when you do not have an existing token * Do not pad-left AdvancedOptionsDropdown * Fix navbar (poorly arranged merge conflicts) * Use tailwind variables for new page * Make Wizards light-mode friendly * Make RadioButton light mode friendly * Make AddNFTCollectionForm (page, not modal) and InviteMembersForm light mode friendly * Make rest of wizard light mode friendly * Adjust input for new background colors * Use the proper collectionKey when adding an NFT from input * Make collectionInput handle blur and errors * Fix nav button position * Fix issue where "transferCouncilMintAuthority" appeared early * Make NFT pulral when != 1 * Feed linter * Bring back normal font thickness * Add proper page titles * Show "min tokens to govern" IFF token supply > 0 * Fix page titles * Use the right class for Program ID on FormSummary * Force user to add council when they do not have a community token * Adjust copy and add punctuation back to page titles * Update logic for forcing a council * make sure pasting in collectionInput field leaves a value * use existingCommunityMintPk to determine communityMintDecimals * Update copy and hide "transferMintAuthority" cells from FormSummary when n/a * Turn off autoComplete by default * Add AdviceBox to AddCouncilForm * Update disabled state of radio buttons * Handle invite members corner case (#6) * Adjust RadioButton disable state (again) * Create a FieldMessage component for display error states not just for Input * Create HOC for TokenInput which uses address input to: * determins whether mint authority can be transferred * get mint suppply, and suggest min tokens to manage DAO * Have AddCouncilForm use the TokenInput component. * Remove unnecessary TokenAddressInput * Use collection count to make sure we don't force a council * NFT DAO creators should auto-join the dao * Allow user to proceed with NFT collection even when unverified. * Remove image placeholder squares in NFTCollectionSelector * Adjust SecondaryButton styling to have better contrast Co-authored-by: Jonathan <jonathan3692bf@users.noreply.github.com> Co-authored-by: Niranjan Ramadas <mail@niranjan.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.