Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 #62

Merged
merged 1 commit into from
Aug 7, 2015
Merged

2.0.0 #62

merged 1 commit into from
Aug 7, 2015

Conversation

jonathantneal
Copy link
Owner

  • Added: UMD pattern and svg4everybody method to activate shim
  • Added: Grunt build process
  • Added: Option to remove legacy code from Grunt
  • Added: Option to customize PNG fallback from browser
  • Updated: SVG External Content feature-deficient browser detection
  • Updated: Exclusive activation on '' children of ''
  • Updated: Preservation of existing viewbox attribute for SVGs
  • Updated: Preservation of existing width and height attributes for PNG fallbacks
  • Updated: Many performance improvements for caching, AJAX, and polling

@jonathantneal jonathantneal mentioned this pull request Aug 1, 2015
Closed
jonathantneal
jonathantneal reviewed Aug 2, 2015
View reviewed changes
lib/svg4everybody.js
}

var uses = document.getElementsByTagName('use');
var requestAnimationFrame = window.requestAnimationFrame || window.setTimeout;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would I save them in the script?

@Rendez
Copy link

Rendez commented Aug 3, 2015

I think we should consider #45. The min version should be part of dist.

@jonathantneal jonathantneal force-pushed the feature/2.0.0 branch 2 times, most recently from 718a060 to a39d276 Compare August 4, 2015 04:40
This was referenced Aug 4, 2015
Closed
Closed
Closed
Closed
Closed
Closed
@jonathantneal jonathantneal force-pushed the feature/2.0.0 branch 16 times, most recently from cee1e5e to baa0f44 Compare August 4, 2015 05:38
@Rendez
Copy link

Rendez commented Aug 4, 2015

Looking great @jonathantneal. Is it working on all the IEs so far?

The only thing is that seems like you created files within dist with legacy=false. Is no IE8 compat. the way we want this plugin to be by default? I think perhaps we should build both? People using bower include dist files directly in their dependencies.

@jonathantneal jonathantneal force-pushed the feature/2.0.0 branch 15 times, most recently from 7270d96 to f0157be Compare August 6, 2015 04:17
@jonathantneal jonathantneal mentioned this pull request Aug 6, 2015
Open
@jonathantneal jonathantneal force-pushed the feature/2.0.0 branch 2 times, most recently from 2ca3265 to 012a98b Compare August 7, 2015 13:15
@shaneog
Copy link

shaneog commented Aug 7, 2015

It would be great to get this merged. Is there anything else holding up the release?

@jonathantneal
Copy link
Owner Author

@shaneog, no. I pinged my coworkers yesterday to review it, and they only recommended I change the name of a few new APIs. Today I pinged my IRC friends and it came back with all thumbs up. It’s 10:30AM where I am. Pending no further changes, I’ll handle the merge, tweet, etc. on my lunch break.

@shaneog
Copy link

shaneog commented Aug 7, 2015

Thanks @jonathantneal.
I only ask since I have been using this branch to gain IE Edge support and the various changes (force pushes) have caused some build issues (i.e. cannot checkout that revision).

@jonathantneal
2.0.0
e546be4 
Added: UMD pattern and `svg4everybody` method to activate shim
Added: Grunt build process
Added: Option to remove legacy code from Grunt
Added: Option to manually shim SVG or External Content from the browser
Added: Option to customize PNG fallback from the browser
Updated: SVG External Content feature-deficient browser detection
Updated: Exclusive activation on '<use>' children of '<svg>'
Updated: Preservation of existing `viewbox` attribute for SVGs
Updated: Preservation of existing `width` and `height` attributes for PNG fallbacks
Updated: Many performance improvements for caching, AJAX, and polling
jonathantneal added a commit that referenced this pull request Aug 7, 2015
@jonathantneal
Merge pull request #62 from jonathantneal/feature/2.0.0
243335b 
2.0.0
@jonathantneal jonathantneal merged commit 243335b into master Aug 7, 2015
@jonathantneal jonathantneal deleted the feature/2.0.0 branch August 7, 2015 17:46
@Rendez
Copy link

Rendez commented Aug 7, 2015

I had some comments sorry I was too busy at work. I'll add them later and before you tag the release :) cheers!

Rendez
Rendez reviewed Aug 7, 2015
View reviewed changes
lib/svg4everybody.js
}

var polyfill = 'polyfill' in opts ? opts.polyfill : LEGACY_SUPPORT ? (
nosvg || /\bEdge\/12\b|\bMSIE [1-8]\b|\bTrident\/[567]\b|\bVersion\/7.0 Safari\b/.test(navigator.userAgent) || (navigator.userAgent.match(/AppleWebKit\/(\d+)/) || [])[1] < 537
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There duplication on this area, which could be reduced in bytes if saved in a variable.

@Rendez Rendez mentioned this pull request Aug 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathantneal @Rendez @iainvdw @shaneog @svemir