Fix price in offering info #59
Conversation
| price = float(price_text.strip().removeprefix("$") or 0) | ||
|
|
||
| else: | ||
| price = 0 |
There was a problem hiding this comment.
This brings up a question for me as to whether or not "no price" is a valid price for a course offering and if that means something different from 0. What are you thoughts?
There was a problem hiding this comment.
@VleraBllacaa Sorry, I was a little quick with the merge, but I'd still be interested in your thoughts.
There was a problem hiding this comment.
@jonbiemond In my view, we can confidently assume that a course will always come with a specific cost. The previous issue arose when the site's structure was altered, causing it to consistently display a price of $0.
To enhance the user experience on our frontend, given that we anticipate having to pay a certain amount, excluding $0, I propose representing a $0 price with a hyphen ("-"). This change will make it less misleading for users, as they might otherwise think the course is free. Additionally, if you encounter a "-" in the price field on the table, it's a clear indicator that there might be script issues or alterations to the webpage's structure.
There was a problem hiding this comment.
@VleraBllacaa A quick check in the database confirms your assumption. I like your idea and have created an issue (#68), feel free to take it on!
|
This looks awesome, thank you so much! Thanks for also updating the test data and tests, I know that's not exactly ideal in the way it is setup now. Perhaps in the future I change it to be pattern matching instead of literal values. And also add a test on live data that can be run periodically. |
I recreated test_data because it was not up to date with the latest website changes.
I fixed also the tests because didn't have the start_time and end_time added in the site (N/A) and also the same for days.