Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit check #29

Closed
jond01 opened this issue Jan 18, 2023 · 0 comments · Fixed by #35
Closed

Add pre-commit check #29

jond01 opened this issue Jan 18, 2023 · 0 comments · Fixed by #35
Labels
enhancement New feature or request

Comments

@jond01
Copy link
Owner

jond01 commented Jan 18, 2023

May be achieved with https://github.com/marketplace/pre-commit-ci.
@jond01 jond01 added the enhancement New feature or request label Jan 18, 2023
@jond01 jond01 mentioned this issue Jan 18, 2023
Merged
jond01 added a commit that referenced this issue Feb 3, 2023
@jond01
Use a dictionary instead of calling to dict (pylint)
973d223 
```
R1735: Consider using '{"context": expected_context}' instead of a call to 'dict'. (use-dict-literal)
```
https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/use-dict-literal.html

No workflow checks pre-commit yet, see #29.
jond01 added a commit that referenced this issue Feb 4, 2023
@jond01
Add a pre-commit check job to the tests workflow
29b0c76 
Resolves #29
@jond01 jond01 mentioned this issue Feb 4, 2023
Merged
jond01 added a commit that referenced this issue Feb 4, 2023
@jond01
Add a pre-commit check job to the tests workflow
365d378 
Resolves #29
jond01 added a commit that referenced this issue Feb 4, 2023
@jond01
Add a pre-commit check job to the tests workflow
b740dbd 
Resolves #29
@jond01 jond01 closed this as completed in #35 Feb 4, 2023
@jond01 jond01 mentioned this issue Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a pre-commit run --all-files check to the tests workflow jond01/xil
1 participant
@jond01