Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest code breaks all graphs #40

Closed
WillPlatnick opened this issue Jan 16, 2013 · 7 comments
Closed

Latest code breaks all graphs #40

WillPlatnick opened this issue Jan 16, 2013 · 7 comments

Comments

@WillPlatnick
Copy link

I pulled down the latest master this morning and all my graphs broke. After a bunch of individual file copying, it seems build/index.js is the culprit. Once I revert to my previous version, graphs work. Process is repeatable.

I will look more into this later...hoping that somebody else has already seen and fixed this to save me some time.

@jondot
Copy link
Owner

jondot commented Jan 16, 2013

Trying this now..

@jondot
Copy link
Owner

jondot commented Jan 16, 2013

Just placed the latest graphene.min.js in an old dashboard to make sure - seems to be working properly.

Can you provide some more info? such as what kind of errors you get (for example, from the javascript console).
Hopefully I can lend a hand

Thanks

@tomvachon
Copy link

I see the same thing.

building [Total Notifications] index.js:12
Uncaught TypeError: Cannot call method 'split' of undefined index.js:12
getUrlParam index.js:12
(anonymous function) index.js:12
w.each.w.forEach index.js:8
(anonymous function) index.js:12
w.each.w.forEach index.js:8
Graphene.build index.js:12
(anonymous function) index.js:12
(anonymous function) example-dash.js:77
(anonymous function) example-dash.js:80
Port error: Could not establish connection. Receiving end does not exist. miscellaneous_bindings:236
chromeHidden.Port.dispatchOnDisconnect miscellaneous_bindings:236

@tomvachon
Copy link

Reverting to acb8016 fixes the undefined

@jondot
Copy link
Owner

jondot commented Jan 16, 2013

Got it, might relate to a misbehaving pull request. I'll check it now and apply a fix soon.

@jondot
Copy link
Owner

jondot commented Jan 16, 2013

Problem was related to a condition where your Graphite source url does not have a query string. Hope this commit helps.

@jondot
Copy link
Owner

jondot commented Jan 17, 2013

@tomvachon @tempspace hope this fix helps? -thanks

@jondot jondot closed this as completed Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants