Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix chalk template path #248

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Conversation

MikeyBeLike
Copy link
Contributor

Seems there was a breaking change in the chalk dependency which moved/renamed the templates file here

This fixes it so it matches the updated path

@lazycoder9
Copy link

@jondot Hi! When we can wait for this fix? It is important for one of our projects and we want to use the latest version of your package, but can't do it due to this issue. Thanks!

@MikeyBeLike
Copy link
Contributor Author

@jondot Hi! When we can wait for this fix? It is important for one of our projects and we want to use the latest version of your package, but can't do it due to this issue. Thanks!

What we've done while we wait for this to get merged:

  • simply copied the contents of lib/logger.js into our own local file, changed
    const template = require('chalk/templates');
    to
    const template = require('chalk/source/templates');
    and used that instead in our tool

@lazycoder9
Copy link

@MikeyBeLike Sounds harder than just downgrade to v5 😄

@jondot jondot merged commit fd0b0fb into jondot:master Apr 24, 2021
jerryjvl added a commit to jerryjvl/hygen that referenced this pull request Jul 11, 2021
jondot#248 fixed a change in Chalk that meant `template` wasn't resolving, but this second copy of the same file was missed, which leads to the command-line help, for example: `hygen generator help`, to not properly render chalk sequences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants