-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to standardize and simplify #34
Conversation
…t each return a single scalar value, and modify longevity so that 'initPop' argument becomes 'lxCrit' as per #16
…calculate per-generation growth rate (closes #27)
…move scalar elements R0 and Tc, as per #12, and re-formatted 'return' section of documentation.
…ent instead of matF and/or matC (R0 has already been updated, so this closes #19). Also includes edits toward standardizing documentation.
…ts to code for readability, added some input validation checks, and made edits toward standardizing documentation
… edits to code for readability, and made edits toward standardizing documentation
…nged default pert parameter to 1e-6, and made small edits to improve code readability and standardize documentation
…rmat (closes #33), and made small edits toward standardizing documentation
…a and stable stage dist, respectively (closes #26)
…n documentation of perturbation fns
@RobSalGo I added a new version of (1) Fecundity or clonality in a stage from which there is no survival If a given stage has positive fecundity or clonality but no survival, the previous version would zero out the sensitivities to fecundity/clonality as it pulled out the (nonexistent) survival component of those vital rates. This version retains those sensitivities — e.g. if there is fecundity but no survival in a given column, the 'full sensitivity' of a fecundity transition is attributed to the fecundity vital rate (and likewise for clonality). (2) Age-based transition in The previous version would return nonzero sensitivites to growth for age-only models, because it effectively assumed that diagonal elements of
I don't mean to 'push through' changes that are still being debated. I'm happy to update the PR with recommended edits :) |
I will merge this pull request. I am in favour of implementing all these changes even though they may (will!) result in some backward compatibility issues. The changes could cause some headaches for workshops (take note @RobSalGo!) if we use existing materials, but since we plan on revamping the materials, and turning them into within-package vignettes I think we will cope. |
dully noted and agreedo @jonesor & @patrickbarks |
Updates primarily to standardize code and documentation, and simplify or split complicated functions.
Resolves the following issues: #7, #13, #16, #19, #23, #24, #25, #26, #27, #28, #29, #30, #31, #32, #33; and partly addresses #12 (I believe Iain is handling the rest of that one). Also pulls matrix-level functions from Rcompadre into Rage, as per jonesor/Rcompadre#28.