Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #43

Merged
merged 8 commits into from
Nov 23, 2018
Merged

Devel #43

merged 8 commits into from
Nov 23, 2018

Conversation

iainmstott
Copy link
Collaborator

Fixed problems thus far...

@patrickbarks
Copy link
Collaborator

I'm not able to install, I think due to the stray test line at the end of subsetDB.

A few more issues picked up by devtools::check():

  • add tibble to imports
  • import head from utils in head.CompadreDB method (my mistake!)
  • example for collapseMatrix fails (suggest adding \dontrun() for now)

@jonesor
Copy link
Owner

jonesor commented Nov 23, 2018

I'm merging the Pull Request. I'll then attempt to tidy up the issues raised by Patrick.

@jonesor jonesor merged commit 84dae72 into jonesor:devel Nov 23, 2018
@jonesor
Copy link
Owner

jonesor commented Nov 23, 2018

Seems to work OK now.
The package builds OK but there are still numerous warnings with devtools::check()

e.g. "no visible binding for global variable", "no visible global function definition", "Undefined global functions or variables", "Undocumented code objects", "Undocumented arguments" etc.

I won't be able to work on this for the next few days, so have at it if you are feeling bold!

@patrickbarks
Copy link
Collaborator

I'll have a go at this tomorrow, if I'm still feeling bold by then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants