Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add back the async bus #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jun 27, 2018

  1. Add proof-of-concept failing tests.

    They're not very good tests, but they do illustrate the problems with
    the current implementation of the futures Sink/Stream.
    habnabit committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    14cc7d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. Implement futures-compatible async bus.

    The implementation is pretty crappy! It's full of TODO comments. I
    didn't reorganize the code in a way that preserves much of the original
    semantic clarity, which was definitely the first mistake. It works, and
    does demonstrate one way of factoring around sometimes blocking and
    sometimes not.
    
    The tests might not be comprehensive enough either. I'm not sure.
    habnabit committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    48f1ed2 View commit details
    Browse the repository at this point in the history