Switch from systray to tray-item package #25
Conversation
This does a minimal change from the systray package to the tray-item package. This implementation can still be cleaned up a bit, but lets check first how well this works. This implementation drops libappindicator support and switches to KSNI on linux.
|
I'd also love to hear from someone who can test this on X with an X tray (like polybar). I don't know if there's support for things like KSNI there? |
I did not realise that was in there, I think I can add it back with this package as well.
I'd say it's a grey area, not much a user can do from a maintenance perspective. If you were to bump the version, I'd suggest we first check for some other things that might warrant a major version bump as well. For example, my other PR is implemented in a backward compatible way right now, but I'd say it's nicer to change the config a bit, the same goes for a change like: #6, which I still think is an improvement structurewise. |
|
Yep, agreed, let's go ahead and make some of those config changes in a new release too! |
|
I am completely swamped right now, but probably have some time over the holidays to get the changes in. |
|
Released as 1.7.0-rc.3 🎉 |
This change includes few but notable changes: - A significant upgrade to the `imap` crate. - Significantly updated parsing for buzz config files (#28), which includes support for user-configured icons. - Support for multiple folders (#24). - A complete swap of the library used for tray icons (#25). From a user's perspective, the main change is that config files need to be updated to match the new format. In particular, this means changing `accounts` from a set of named tables to an array of tables, and moving from `folder = "something"` to `folders = ["something"]`. See the README for an updated example config. Big thanks to @DanielVoogsgerd for the changes in this release!
This does a minimal change from the systray package to the tray-item package. The implementation can still be cleaned up a bit, but let's check first how well this works.
The implementation drops libappindicator support and switches to KSNI on Linux.
I'm not against the inclusion of the libappindicator support, however I think this would need a GTK event loop.
I tested this on waybar, and it seems to work for me.
Furthermore, I think the old implementation did not work on Windows and macOS, this one might.
fixsee also: #6EDIT: Changed the fix reference to see also, as it does not entirely fix this issue. It just makes it easier to implement it.