Add screenshot method #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! This looks like a good addition, thanks! |
jonhoo
reviewed
May 29, 2018
src/error.rs
Outdated
| @@ -106,6 +106,9 @@ pub enum CmdError { | |||
|
|
|||
| /// A function was invoked with an invalid argument. | |||
| InvalidArgument(String, String), | |||
|
|
|||
| /// Base64 decode error | |||
There was a problem hiding this comment.
We should be more specific here. Perhaps ImageDecodeError? And then with an appropriate comment.
jonhoo
reviewed
May 29, 2018
src/error.rs
Outdated
| @@ -142,6 +145,7 @@ impl Error for CmdError { | |||
| CmdError::Json(..) => "webdriver returned incoherent response", | |||
| CmdError::NotW3C(..) => "webdriver returned non-conforming response", | |||
| CmdError::InvalidArgument(..) => "invalid argument provided", | |||
| CmdError::Base64DecodeError(..) => "Base64 decode error", | |||
There was a problem hiding this comment.
Similarly here; I'd prefer to see the message relate to image decoding.
jonhoo
reviewed
May 29, 2018
src/lib.rs
Outdated
| .issue_wd_cmd(WebDriverCommand::TakeScreenshot) | ||
| .and_then(|(_, src)| { | ||
| if let Some(src) = src.as_string() { | ||
| return decode(src).map_err(error::CmdError::from); |
There was a problem hiding this comment.
I think I'd prefer base64::decode here rather than the top-of-file use base64::decode.
jonhoo
reviewed
May 29, 2018
src/lib.rs
Outdated
| @@ -1045,6 +1048,19 @@ impl Client { | |||
| self.current_url_().map(|(_, u)| u) | |||
| } | |||
|
|
|||
| /// Get a PNG screenshot of the current page. | |||
There was a problem hiding this comment.
Can we make this "Get a PNG-encoded screenshot of the current page."?
|
+1 |
|
Will do. I'll get to fixing it in the upcoming days. |
Closed
|
Fixed |
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.