Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0 with ahash bump #121

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Release 0.5.0 with ahash bump #121

merged 4 commits into from
Feb 11, 2024

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Feb 11, 2024

See individual commits for context.


This change is Reviewable

This is a breaking change.
However, at least future bumps of ahash now won't be.

Closes #119.
Note that for most users, this major version should be trivial to adopt.
@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2024

Miri is still unhappy about one of our tree walking paths 👀
@ibraheemdev Did you ever end up having a look at that (or am I misremembering and you never said you would)?

@jonhoo jonhoo merged commit 48ff2e6 into main Feb 11, 2024
16 of 18 checks passed
@jonhoo jonhoo deleted the ahash-bump branch February 11, 2024 10:36
@ibraheemdev
Copy link
Collaborator

Hm, I don't remember any active Miri issues. Do you know if there was a specific commit that caused it?

@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2024

No, I think this one has been with us for quite some time. Like, I see miri failures all the way back to 11608d2 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants