-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests #61
Add more tests #61
Conversation
Codecov Report
|
(CI failure is due to |
Should I fix the ci issue? |
No, just leave it -- it'll likely be fixed tomorrow-ish. |
Are there some tests / benchmarks that you would like to have in Flurry? |
The tests that I know of are the JDK tests, the JSR166 tests, and the |
I think all tests are implemented that are compatible with flurry. |
Thanks for working on this! A few comments from looking through the diff:
|
Wonderful! Don't know why one of the CI targets failed, but all of my comments have been addressed with the new commits and this seems to be unrelated to the code, so I'm happy to approve this now. |
The miri failure is because miri was broken on the last nightly. I think the newest one has it again though, so I'll re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I only have one remaining request I think: it'd be good if the new test files you've added that are ports of tests from elsewhere have that reflected in the name. If they are from the JDK test suite, then add them under the jdk
directory. If they are from the JSR166 test suite, add them under a jsr166
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 5 files at r3, 5 of 5 files at r4, 2 of 2 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved
🎉 Thank you! |
This PR adds several tests to increase the test coverage and more benchmarks.
This change is