Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump major version of dependencies #92

Closed
wants to merge 2 commits into from
Closed

Bump major version of dependencies #92

wants to merge 2 commits into from

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Aug 28, 2020 •
edited
Loading

This is a breaking change since ahash is public through DefaultHashBuilder.

I wonder if we might want to wrap it in a newtype for the future?

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #92 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/map.rs 84.44% <0.00%> (-0.19%) ⬇️
src/node.rs 74.27% <0.00%> (+0.26%) ⬆️
src/raw/mod.rs 88.34% <0.00%> (+1.94%) ⬆️

@ibraheemdev
Copy link
Collaborator

ibraheemdev commented Mar 29, 2022 •
edited
Loading

Superseded by #105.

@jonhoo
Copy link
Owner Author

jonhoo commented Mar 29, 2022 •
edited
Loading

I do still wonder if we want to hide ahash from our public APIs though 🤔

@ibraheemdev
Copy link
Collaborator

I don't see why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhoo @ibraheemdev