Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with hashbrown 0.11.2 #18

Merged
merged 1 commit into from
May 4, 2021
Merged

Work with hashbrown 0.11.2 #18

merged 1 commit into from
May 4, 2021

Conversation

PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Apr 27, 2021

Hi @jonhoo , this is the smallest PR to work with hashbrown 0.11.2 , would you mind merging it and releasing griddle 0.4.2?

Relate: #17

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #18 (1a57c28) into master (fe43dde) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/map.rs 63.34% <100.00%> (+0.14%) ⬆️
src/raw/mod.rs 69.72% <100.00%> (ø)

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to look into this! I left some comments inline.

Out of curiosity, how did you land on these changes in particular? Did you diff the files, or just see what didn't compile?

src/map.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@PsiACE
Copy link
Contributor Author

PsiACE commented May 3, 2021

Out of curiosity, how did you land on these changes in particular? Did you diff the files, or just see what didn't compile?

I did diff all the files, but in the end I decided to consider the compilation problem first. This allows us to have a preview, and then the overall migration will be completed when we are free.

@jonhoo jonhoo merged commit f8e133d into jonhoo:master May 4, 2021
@jonhoo
Copy link
Owner

jonhoo commented May 4, 2021

Released (with some other fixes) as 0.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants