Filter out lines which begin with '# ' in inferno-flamegraph #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #237
also fixes #238 by moving the check for empty/ignored lines out of
merge
and intofrom_lines
. I think this makes more sense as the block infrom_lines
which handlesopt.reverse_stack_order
pre-processes the samples before callingmerge
, and seems to assume that the lines it deals with are not empty. I'm not very experienced with rust though, so please let me know if there is a better way!I've added an empty line to the
bad-lines
test file as a regression test for #238, and a couple of test files for input from the austin profiler.