-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapse benchmarks #88
Conversation
Should we run these on CI somehow? I'm a little sad that perf has to go through decoding, but it may be necessary if we don't want to pull in the entire decompressed file. |
My experience is I wouldn't, for once they take a long time (3 minutes on my machine) and then especially free CI services are so unreliable performance wise that run to run variance is much to high to give meaningful results. |
Good point. I'd like to at least see a section in the In fact, thinking about it some more, maybe the perf benchmark should first decompress and write the stacks to a temporary file, and then run the benchmark on that decompressed file. |
The benchmark itself is purely run on memory, I wanted to take the IO out of it since we can't affect that part of the performance :). |
Ah, yes, I misread the code and though you were doing the I/O as part of the benchmark! Ignore me 😅 |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 14 14
Lines 1442 1442
=======================================
Hits 1302 1302
Misses 140 140 Continue to review full report at Codecov.
|
No description provided.