Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update rubocop-rspec: 1.30.1 → 1.33.0 (minor) #44

Merged
merged 1 commit into from
May 14, 2019

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 14, 2019

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (1.30.1 → 1.33.0) · Repo · Changelog

Release Notes

1.33.0

  • Let RSpec/DescribedClass pass Struct instantiation closures. (@schmijos)
  • Fixed RSpec/ContextWording missing contexts with metadata. (@pirj)
  • Fix FactoryBot/AttributeDefinedStatically not working with an explicit receiver. (@composerinteralia)
  • Add RSpec/Dialect enforces custom RSpec dialects. (@gsamokovarov)
  • Fix redundant blank lines in RSpec/MultipleSubjects's autocorrect. (@pirj)
  • Drop support for ruby 2.2. (@bquorning)

1.32.0

  • Add RSpec/Yield cop, suggesting using the and_yield method when stubbing a method, accepting a block. (@Darhazer)
  • Fix FactoryBot/CreateList autocorrect crashing when the factory is called with a block=. (@Darhazer)
  • Fixed RSpec/Focus not flagging some cases of RSpec.describe with focus: true. (@Darhazer)
  • Fixed RSpec/Pending not flagging some cases of RSpec.describe with :skip. (@Darhazer)
  • Fix false positive in RSpec/ReceiveCounts when method name exactly, at_least or at_most is used along with times, without being an RSpec API. (@Darhazer)

1.31.0

  • Add IgnoreSharedExamples option for RSpec/NamedSubject. (@RST-J)
  • Add autocorrect support for Capybara/CurrentPathExpectation cop. (@ypresto)
  • Add support for built-in exists matcher for RSpec/PredicateMatcher cop. (@mkenyon)
  • SingleArgumentMessageChain no longer reports an array as it's only argument as an offense. (@Darhazer)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 55 commits:

✳️ rubocop (0.68.1 → 0.69.0) · Repo · Changelog

Release Notes

0.69.0

New features

  • Add support for subclassing using Class.new to Lint/InheritException. (@houli)
  • #6779: Add new cop Style/NegativeUnless that checks for unless with negative condition. (@tejasbubane)

Bug fixes

  • #6900: Fix Rails/TimeZone autocorrect Time.current to Time.zone.now. (@vfonic)
  • #6900: Fix Rails/TimeZone to prefer Time.zone.#{method} over other acceptable corrections. (@vfonic)
  • #7007: Fix Style/BlockDelimiters with braces_for_chaining style false positive, when chaining using safe navigation. (@Darhazer)
  • #6880: Fix .rubocop file parsing. (@hoshinotsuyoshi)
  • #5782: Do not autocorrect Lint/UnifiedInteger if TargetRubyVersion < 2.4. (@lavoiesl)
  • #6387: Prevent Lint/NumberConversion from reporting error with Time/DateTime. (@tejasbubane)
  • #6980: Fix Style/StringHashKeys to allow string as keys for hash arguments to gsub methods. (@tejasbubane)
  • #6969: Fix a false positive with block methods in Style/InverseMethods. (@dduugg)
  • #6729: Handle array spread for change_column_default in Rails/ReversibleMigration cop. (@tejasbubane)
  • #7033: Fix an error for Layout/EmptyLineAfterGuardClause when guard clause is a ternary operator. (@koic)

Changes

  • #6945: Drop support for Ruby 2.2. (@koic)
  • #6945: Set default EnforcedStyle to squiggly option for Layout/IndentHeredoc and auto_detection option is removed. (@koic)
  • #6945: Set default EnforcedStyle to always option for Style/FrozenStringLiteralComment and when_needed option is removed. (@koic)
  • #7027: Allow unicode/display_width dependency version 1.6.0. (@tagliala)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:

↗️ unicode-display_width (indirect, 1.5.0 → 1.6.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 14, 2019
@jonhue jonhue merged commit 084e11c into master May 14, 2019
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.33.0 branch May 14, 2019 14:11
@jonhue jonhue mentioned this pull request Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant