Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

[#48] Relax json dependency #49

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Conversation

paulca
Copy link
Contributor

@paulca paulca commented Jul 7, 2019

  • The dependency on JSON for what it provides this gem is not
    affected by whether it's 1.x or 2.x
  • Other omniauth strategies (and older gems in general) depend
    on json 1.7. This lib works just fine with 1.7

Description

I relaxed the dependency in the gemspec file.

Resolves #48

- The dependency on JSON for what it provides this gem is not
  affected by whether it's 1.x or 2.x
- Other omniauth strategies (and older gems in general) depend
  on json 1.7. This lib works just fine with 1.7
@paulca
Copy link
Contributor Author

paulca commented Jul 7, 2019

(force-pushed an update after failing spec because I hadn't included the changed Gemfile.lock, but obviously it is required since there's a dependency change)

Copy link
Owner

@jonhue jonhue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@jonhue jonhue added the enhancement New feature or request label Jul 7, 2019
@jonhue jonhue merged commit 5fc0af8 into jonhue:master Jul 7, 2019
@jonhue jonhue mentioned this pull request Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax json version requirement
2 participants