Rename IUIComponentLogger to ILogger, make it usable by other types #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to object BREAKING CHANGE: The IUIComponentLogger interface has been renamed to ILogger. It's methods' second argument is now of type object rather than UIComponent.
BREAKING CHANGE: UIComponent's GetTypeName method has been removed as it was unnecessary. Use GetType().Name instead.
jonisavo
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 467 464 -3
=========================================
- Hits 467 464 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IUIComponentLoggerhas been renamed toILogger. The caller argument is now of typeobject, which makes the interface usable by any type. This ensures that ProvideAttribute can be used by non-UIComponent types, as long as they have aLoggerinstance variable which has the correct methods. That behaviour should be refined further before 1.0 release.