Disable strict in bundles #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the code is not designed with strict in mind and rollup automatically adds "use strict;" at the top of generated bundles, we get all sorts of issues on runtime. One error i've encountered is in `mxCellRenderer.prototype.isTextShapeInvalid` where in function `check`, `result` is not defined in strict mode. This PR just disables `use strict;` in rollup, as fixing the underlying code could add to many regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the code is not designed with strict in mind and rollup automatically adds "use strict;" at the top of generated bundles, we get all sorts of issues on runtime. One error i've encountered is in
mxCellRenderer.prototype.isTextShapeInvalidwhere in functioncheck,resultis not defined in strict mode.This PR just disables
use strict;in rollup, as fixing the underlying code could add to many regressions.