Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring rspec doesn't respect rspec's default file matching pattern #7

Closed
george opened this issue Jan 23, 2014 · 11 comments
Closed

spring rspec doesn't respect rspec's default file matching pattern #7

george opened this issue Jan 23, 2014 · 11 comments

Comments

@george
Copy link

george commented Jan 23, 2014

OS X: 10.8.5

∴ rails -v
Rails 4.1.0.beta1

∴ glg spring
spring (1.1.0)
spring-commands-rspec (1.0.1)

∴ rspec -v
2.14.7

Running a bare rspec command correctly picks up all example files matching the pattern: spec/**/*_spec.rb (per the spec).

∴ rspec
.........

Finished in 0.89628 seconds
9 examples, 0 failures

However, running spring rspec either does nothing or doesn't find the examples. Here I run spring rspec 3 times:

∴ spring rspec
projekt/ on rails_4.1.0.beta1
∴ spring rspec
projekt/ on rails_4.1.0.beta1
∴ spring rspec
projekt/ on rails_4.1.0.beta1
∴ No examples found.


Finished in 0.00033 seconds
0 examples, 0 failures

I've also tried adding --default_path specs to my .rspec file, with the unexpected behavior persisting.

Any ideas what I'm doing wrong or how I can fix it? I'm more than happy to contribute, I just need a little direction. Thanks.

@miharekar
Copy link

Same here. Let me know how to fix this. I got it working with spring rspec spec/ but that should be the default, right?

@lucasmazza
Copy link

I'm having the same issues, and the binstub produced by spring binstub rspec displays the same problem.

@lucasmazza
Copy link

This issue isn't present when downgrading Spring to the 1.0.0 version.

@phyllisstein
Copy link

I had the same problem, but downgrading helped me as well.

@brendonrapp
Copy link

I'm observing an issue with 1.0.1 in which spring rspec runs all specs, but if I add arguments for rspec (eg. spring rspec --format doc), then it runs no specs.

Following @mrfoto's lead, I found that adding the spec/ argument after rspec (eg. spring rspec spec/ --format doc) solves the problem. But it seems like this is not the intended behavior.

@jonleighton
Copy link
Owner

@brendonrapp try upgrading your version of spring, it should be fixed

@Hussein1147
Copy link

hello everyone, im running rspec spec with rails 4.0.4 and it is throwing this,

No examples found.

Finished in 0.00012 seconds
0 examples, 0 failures

Randomized with seed 41862

here is my spec directory structure:
spec
controllers
pages_controller_spec.rb

@tbuehlmann
Copy link

@Hussein1147, have you tried updating spring to version 1.1.2?

@Hussein1147
Copy link

Problem solved, i had to generate controllers.

@LandonSchropp
Copy link

I'm experiencing the same problem as @Hussein1147 using Spring 1.1.2. Running spring rspec spec/ works for me, but that doesn't work with Guard.

@maxim
Copy link

maxim commented Jul 16, 2014

Some additional input on this issue here at #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants