Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #66 - Update omit_username -> override_username following core changes #67

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

davidtaylorhq
Copy link
Contributor

This commit maintains backwards compatibility with older Discourse changes

This commit maintains backwards compatibility with older Discourse changes
@jonmbake jonmbake merged commit 83c463f into jonmbake:master Dec 29, 2021
@jonmbake jonmbake changed the title Update omit_username -> override_username following core changes Fixes #66 - Update omit_username -> override_username following core changes Dec 29, 2021
@jonmbake
Copy link
Owner

Thanks for submitting this PR, @davidtaylorhq! I appreciate it.

@JimboJoe
Copy link

JimboJoe commented Aug 9, 2022

Hi, looks like we need a formal release of this fix with latest 2.8.7 version of Discourse (see here for the corresponding issue in the YunoHost package). Are you planning to do a release any time soon?

@jonmbake
Copy link
Owner

@JimboJoe Discourse should pull in the most recent version of this plugin w/o having to bump the plugin release version. We can bump the version today, but it shouldn't be necessary to get this change. Are you sure the issue is related to this?

@JimboJoe
Copy link

I've tested with the latest version of your (great!) plugin and it fixes the problem (we actually upgraded our YunoHost package from 2.7 to 2.8)!
We can't upgrade "simply" this plugin as it is automatically installed during the YunoHost package installation (with LDAP auto-configuration for YunoHost), and this installation mode without git prevents upgrade.
And our current issue is quite critical as people (and in particular admins!) can't currently access the forum... 😅
Thanks in advance!

@jonmbake
Copy link
Owner

OK, @JimboJoe . Version 0.6.0 has been released: https://github.com/jonmbake/discourse-ldap-auth/releases/tag/v0.6.0.

@JimboJoe
Copy link

Thanks a lot!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants