Fix Zygote accum for CA in GPU broadcasting #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 73.16% 73.24% +0.07%
==========================================
Files 22 23 +1
Lines 723 725 +2
==========================================
+ Hits 529 531 +2
Misses 194 194
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Related to #186, I think |
Not really. I think it is mostly on AMDGPU side not being very robust to broadcasting. I have faced it in places completely detached from Zygote and CAs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing my saga of upstreaming pirated patches from Lux. Zygote + AMDGPU + CAs.jl don't play too well. See https://buildkite.com/julialang/lux-dot-jl/builds/634#018ab9ff-bbcb-47bf-aa05-079929053253/6-4602.
This is mostly a hacky patch, but it fixes it.